Skip to content

use GridDraggable instead of Column in SolaraViz #2344

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

wang-boyu
Copy link
Member

This PR brings back the draggable and resizable Solara layout that was in the old Solara viz (now experimental).

@wang-boyu wang-boyu added the enhancement Release notes label label Oct 10, 2024
@wang-boyu wang-boyu requested review from rht, Corvince and EwoutH October 10, 2024 19:23
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +1.1% [+0.2%, +1.9%] 🔵 -0.2% [-0.4%, -0.1%]
BoltzmannWealth large 🔵 -0.8% [-1.6%, -0.1%] 🔵 -0.4% [-1.4%, +0.6%]
Schelling small 🔵 -0.2% [-0.4%, +0.1%] 🔵 +0.1% [-0.1%, +0.3%]
Schelling large 🔵 -0.0% [-1.2%, +1.0%] 🔵 +0.0% [-1.4%, +1.5%]
WolfSheep small 🔵 -0.6% [-0.9%, -0.4%] 🔵 +0.4% [+0.2%, +0.6%]
WolfSheep large 🔵 -1.6% [-2.4%, -0.7%] 🔵 +0.1% [-1.9%, +2.3%]
BoidFlockers small 🔵 -1.1% [-1.5%, -0.6%] 🔵 +1.0% [+0.3%, +1.7%]
BoidFlockers large 🔵 -0.3% [-0.6%, +0.1%] 🔵 +1.3% [+0.9%, +1.7%]

@EwoutH
Copy link
Member

EwoutH commented Oct 10, 2024

If I understand this correctly, I really like this conceptually!

I will test it tomorrow. Thanks for working on this, the visualization deserves more love!

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks goods and works well. Thanks!

One small remark: It looks like it only rescales on width, and not on height. Maybe we want to modify it that it also follows the maximum height:

image

But this isn't blocking, and can be done in another PR.

@rht rht merged commit a8e2b83 into projectmesa:main Oct 11, 2024
13 of 14 checks passed
@wang-boyu wang-boyu deleted the viz/solara-griddraggable branch October 11, 2024 13:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants