-
Notifications
You must be signed in to change notification settings - Fork 987
Fix #2452 - handle solara viz model params better #2454
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Performance benchmarks:
|
I had a look at this yesterday and my approach would be to change |
A few minor comments, but great to see you working on this. |
Updated the logic, added tests and reverted temporary example changes. Also moved the checking to |
Performance benchmarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestions (probably a left over from testing) and then this is good to be merged.
for more information, see https://pre-commit.ci
Co-authored-by: Jan Kwakkel <j.h.kwakkel@tudelft.nl>
for more information, see https://pre-commit.ci
Summary
Bug description is in #2452, here is a copy
Implementation
model.__class__.__init__
. If there are are parameters that don't have a default value but are not in user_params solara viz will raise a ValueError. Also raises ValueError if user provided model_params include parameters not used by the model.