Explicitly handle redirects when doing POST requests #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/post-redirect
branch
2 times, most recently
from
3115bc9 to
43f2d65
Compare
DebakelOrakel
approved these changes
Dec 31, 2024
We Explicitly redo `POST` requests if we get a 301, 302, 307 or 308 status code for the first call. We don't validate that the redirect location has the same domain as the original request, since we already unconditionally follow redirects with the bearer token for GET requests. Note that this wouldn't be necessary if all Lieutenant APIs would redirect us with a 308 for POST requests.
simu
force-pushed
the
fix/post-redirect
branch
from
43f2d65 to
1724311
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We explicitly redo
POSTrequests if we get a 301, 302, 307 or 308 status code for the first call. We don't validate that the redirect location has the same domain as the original request, since we already unconditionally follow redirects with the bearer token for GET requests.Note that this wouldn't be necessary if all Lieutenant APIs would redirect us with a 308 for POST requests.
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog