#258 Document running as non-superuser on PostgreSQL versions 10 or newer. #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewer. Signed-off-by: juris.greitans <juris.greitans@visma.com>
mbanck
reviewed
Nov 26, 2021
README.md
Outdated
| data with the non-superuser. Only creating the views will leave out the most | ||
| important bits of data. | ||
| To be able to collect metrics from `pg_stat*` views as non-superuser in PostgreSQL | ||
| server versions >= 10 you can grant pg_monitor built-in role to the user. If |
There was a problem hiding this comment.
"you can grant the pg_monitor built-in role" I'd say, maybe also markup pg_monitor with backticks, like pg_stat* before.
Also, I guess technically the pg_read_all_stats role would suffice, so maybe mention both
There was a problem hiding this comment.
Fixed. PostgreSQL documentation says that pg_monitor is a member of pg_read_all_stats, that's why I went with pg_monitor.
Also, I added a link to pre-defined role documentation.
…about pre-defined roles. Signed-off-by: juris.greitans <juris.greitans@visma.com>
mbanck
approved these changes
Nov 30, 2021
|
Why is merging still blocked on this? |
|
I guess my vote doesn't count for a lot |
sysadmind
approved these changes
Jan 26, 2022
ritbl
pushed a commit
to heniek/postgres_exporter
that referenced
this pull request
Mar 19, 2023
percona#258 Document running as non-superuser on PostgreSQL versions 10 or newer.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from version 10, PostgreSQL includes a built-in role
pg_monitormeant for use by monitoring tools. This PR adds documentation about granting the role when running postgres_exporter as non-superuser. Fixes #258.