Skip to content

Add gRPC request duration histogram #235

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Add gRPC request duration histogram #235

wants to merge 1 commit into from

Conversation

Sverdel
Copy link

@Sverdel Sverdel commented Aug 18, 2020

I think, it would be nice to have duration histogram for grpc request just like for http requests. Unfortunately, HttpRequestDurationMiddleware can't be used, because it know nothing about gRPC method name. So I add GrpcRequestDurationMiddleware and all infrastructure for it

@Sverdel
Copy link
Author

Sverdel commented Aug 28, 2020

@sandersaares, if you have any doubts about this PR, please, let me know

@Mario-Hofstaetter
Copy link

@sandersaares Any update on this PR? Thanks

@EraYaN
Copy link

EraYaN commented Oct 18, 2021

I rebased this PR to v5.0.1 here: https://github.com/calcasa/prometheus-net/tree/grpc-histogram

You can pull that one to update this PR (or replicate the results)

@EraYaN
Copy link

EraYaN commented Mar 17, 2022

Rebased this PR to 6.0.0 to that same branch

@rui-wang-imprivata
Copy link

@sandersaares @EraYaN @Mario-Hofstaetter @Sverdel Hi All, I saw another similar PR: #340, not sure which one will be merged, is there any update ?

@EraYaN
Copy link

EraYaN commented Nov 10, 2022

@Sverdel Sverdel closed this by deleting the head repository Aug 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants