Avoid allocations for single label value #486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling a method with a single value for a params argument allocates memory. This change will prevent that for the common scenario of having only one label, by introducing a non-allocating method.
avendel
force-pushed
the
perf-single-label-value
branch
from
c0e3895 to
24f72c3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the
WithLabelsoverloads uses a params argument. Calling a method with a single value for a params argument allocates memory, and I suspect that using a single label is quite common.This change will prevent that for the common scenario of having only one label, by introducing a non-allocating method.
Benchmark results