Keep 'container_fs_.*' metrics from cAdvisor #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
dgrisonnet
approved these changes
Sep 28, 2021
This was referenced Sep 28, 2021
philipgough
referenced
this pull request
in philipgough/cluster-monitoring-operator
Sep 28, 2021
This pulls in the changes made in https://github.com/prometheus-operator/kube-prometheus/pull/1402\
2 tasks
dgrisonnet
referenced
this pull request
in dgrisonnet/cluster-monitoring-operator
Sep 5, 2023
This pulls in the changes made in https://github.com/prometheus-operator/kube-prometheus/pull/1402\
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the discussion and investigation in #1396, it has become apparent that dropping these particular metrics might become problamatic for users of certain environments who have come to depend on them.
We believed when making the change, that the info provided by these metrics would still be available at a slice level. However in some cases (docker driver?) this appears not to be the case.
As per #1396 (comment) the original change should have been valid but given that it can cause issues, this change reverts the drop.
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.