Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

allow specification of source address for probes (http, grpc) #1097

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FOWind
Copy link

@FOWind FOWind commented Jul 8, 2023

Related issue: #1096

Currently icmp, tcp, dns probers have supported to specify the source address by source_ip_address configuration. :#262

Http and grpc prober also need this features , I found #765 was working on http prober but didn't continue to finish.

This adds the configuration option source_ip_address to modules HTTP and GRPC which changes the
prober's local address.

FOWind added 2 commits July 8, 2023 17:22
This adds the configuration option source_ip_address
to modules HTTP and GRPC which changes the
prober's local address.
@asokolov365
Copy link

Hi @FOWind
What's the status of the PR? I see the DCO check's failed. Is it the only reason why the PR is not merged yet?
Thank you!

@FOWind
Copy link
Author

FOWind commented Nov 17, 2023

Hi @asokolov365
I think it's not a necessary feature for the blackbox_exporter, so there is no response to this PR from maintainers.

At the same time, I found many same feature request from ISSUE lists

@github-actions github-actions bot added the stale label Sep 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants