Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

examples: Add custom labels example #1626

Merged
merged 3 commits into from
Sep 19, 2024
Merged

examples: Add custom labels example #1626

merged 3 commits into from
Sep 19, 2024

Conversation

ying-jeanne
Copy link
Contributor

@ying-jeanne ying-jeanne commented Sep 15, 2024 •
edited
Loading

Fixes: #1585, tested in local. @bwplotka @ArthurSens @kakkoyun

@ying-jeanne
examples: Add custom labels example
b079872 
Signed-off-by: Ying WANG <ying.wang@grafana.com>
bwplotka
bwplotka approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One nit, otherwise LGTM 👍🏽

ying-jeanne and others added 2 commits September 18, 2024 09:20
@ying-jeanne @bwplotka
Update examples/customlabels/main.go
6efd27d 
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Ying WANG <74549700+ying-jeanne@users.noreply.github.com>
@ying-jeanne
Merge branch 'main' into add-example-for-customlabels
86cdda8
@ying-jeanne
Copy link
Contributor Author

Thanks! One nit, otherwise LGTM 👍🏽

thanks for the review :), corrected so bad you don't like my service name.

ArthurSens
ArthurSens approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ArthurSens ArthurSens merged commit 64158c5 into prometheus:main Sep 19, 2024
10 checks passed
This was referenced Feb 19, 2025
Open
Merged
@dghubble-renovate dghubble-renovate bot mentioned this pull request Feb 19, 2025
Merged
1 task
@mr-borboto mr-borboto bot mentioned this pull request Feb 19, 2025
Open
1 task
@pull-bunyan pull-bunyan bot mentioned this pull request Feb 19, 2025
Open
1 task
@pb-renovate pb-renovate bot mentioned this pull request Feb 19, 2025
Open
1 task
@theriver-bot theriver-bot bot mentioned this pull request Feb 19, 2025
Merged
1 task
@larsl-renovate larsl-renovate bot mentioned this pull request Feb 19, 2025
Open
1 task
@cilium-renovate cilium-renovate bot mentioned this pull request Feb 17, 2025
Merged
1 task
This was referenced Feb 19, 2025
Merged
Merged
Merged
Open
@rwunderer rwunderer mentioned this pull request Feb 19, 2025
Merged
1 task
This was referenced Feb 19, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Merged
This was referenced Feb 21, 2025
Merged
Open
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Open
Merged
Open
Closed
Merged
Open
Merged
Open
Open
Open
@renovate-bot-for-keyhub renovate-bot-for-keyhub bot mentioned this pull request Feb 22, 2025
Open
1 task
This was referenced Feb 22, 2025
Merged
Open
This was referenced Feb 22, 2025
Open
Merged
@renovate-rancher renovate-rancher bot mentioned this pull request Feb 22, 2025
Open
1 task
This was referenced Feb 22, 2025
Open
Merged
@renovate-rancher renovate-rancher bot mentioned this pull request Feb 22, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Feb 22, 2025
Merged
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@ArthurSens ArthurSens ArthurSens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to add go runtime metrics, with self-define label?
3 participants
@ying-jeanne @bwplotka @ArthurSens