-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
exposition format: Move protobuf format to proto3 #549
Comments
Just keep in mind that the text format should have the same capability. |
The text format already has this capacity. |
What capability/capacity are you referring to? (And are you referring to the same one?) |
"The capability" seems to be,
|
* op-guide, tool: add summary metadata (prometheus#548) * op-guide: add summary metadata * op-guide: add summary metadata#2 * tool: add summary metadata * op-guide: address comment * *: add summary metadata to 63 docs files (prometheus#549) * *: add summary metadata to 63 docs files * tikv: update summary wording
Since our current use of protobuf for exposition is going away, and the new way that might come with OpenMetrics will be done from scratch, this issue is obsolete. |
Since proto3 has no "unset" values anymore, we need to have all the values that may be "unset" (and where that has a meaning different from "default value") to be
repeated
, specifying that the value is repeated either zero times or once.While doing so, we could also allow multiple samples in a single protobuf message (which must be timestamped then). This has to be added in the spec.
All these changes are backwards compatible with the proto2 protobufs.
See relevant discussion in prometheus/client_model#13
The text was updated successfully, but these errors were encountered: