Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

exposition format: Move protobuf format to proto3 #549

Closed
beorn7 opened this issue Sep 9, 2016 · 5 comments
Closed

exposition format: Move protobuf format to proto3 #549

beorn7 opened this issue Sep 9, 2016 · 5 comments

Comments

@beorn7
Copy link
Member

beorn7 commented Sep 9, 2016

Since proto3 has no "unset" values anymore, we need to have all the values that may be "unset" (and where that has a meaning different from "default value") to be repeated, specifying that the value is repeated either zero times or once.

While doing so, we could also allow multiple samples in a single protobuf message (which must be timestamped then). This has to be added in the spec.

All these changes are backwards compatible with the proto2 protobufs.

See relevant discussion in prometheus/client_model#13

@RichiH
Copy link
Member

RichiH commented Sep 9, 2016

Just keep in mind that the text format should have the same capability.

@brian-brazil
Copy link
Contributor

The text format already has this capacity.

@beorn7
Copy link
Member Author

beorn7 commented Sep 11, 2016

Just keep in mind that the text format should have the same capability.

The text format already has this capacity.

What capability/capacity are you referring to? (And are you referring to the same one?)

@rektide
Copy link
Contributor

rektide commented Nov 8, 2017

What capability/capacity are you referring to? (And are you referring to the same one?)

"The capability" seems to be,

While doing so, we could also allow multiple samples in a single protobuf message (which must be timestamped then).

aylei pushed a commit to aylei/docs that referenced this issue Oct 28, 2019
* op-guide, tool: add summary metadata  (prometheus#548)

* op-guide: add summary metadata

* op-guide: add summary metadata#2

* tool: add summary metadata

* op-guide: address comment

* *: add summary metadata to 63 docs files (prometheus#549)

* *: add summary metadata to 63 docs files

* tikv: update summary wording
@beorn7
Copy link
Member Author

beorn7 commented Nov 28, 2019

Since our current use of protobuf for exposition is going away, and the new way that might come with OpenMetrics will be done from scratch, this issue is obsolete.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants