Fix Nil pointer references for WebSystemdSocket #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-gallant
changed the title
ethan-gallant
force-pushed
the
master
branch
from
b325bb2 to
5cbf819
Compare
ethan-gallant
changed the title
ethan-gallant
force-pushed
the
master
branch
3 times, most recently
from
589e116 to
114ce37
Compare
SuperQ
requested changes
Mar 2, 2023
roidelapluie
reviewed
Mar 7, 2023
|
This needs a DCO sign-off. You can use |
|
@SuperQ should be good to go. Squashed commits and amended to have the signature |
SuperQ
reviewed
Mar 8, 2023
SuperQ
requested review from
dswarbrick and
roidelapluie
and removed request for
dswarbrick
SuperQ
reviewed
Mar 8, 2023
Signed-off-by: Ethan J. Gallant <ethan.gallant@acquia.com> Co-authored-by: William Van Hevelingen <William.VanHevelingen@acquia.com> Co-authored-by: Stephanie Palis <35511514+stephpalis@users.noreply.github.com> change to var
SuperQ
approved these changes
Mar 9, 2023
|
Thanks! |
SuperQ
added a commit
that referenced
this pull request
May 1, 2023
* [FEATURE] Client TLS: Add option to require a specific Subject Alternate Names #126 * [FEATURE] Add a POST form to the landing page #144 * [FEATURE] Add generic customization to landing page #146 * [ENHANCEMENT] Add a Content-Type header to the landing page #142 * [BUGFIX] Fix Nil pointer references for WebSystemdSocket #127 Signed-off-by: SuperQ <superq@gmail.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when working with https://github.com/Lusitaniae/apache_exporter
If you don't provide a boolean value for WebSystemdSocket (default false) calling ListenAndServe causes the application to SigSegv. This checks if it is nil before evaluating the boolean value.