Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tls_config.go: don't swallow error #232

Merged
merged 1 commit into from
Aug 7, 2024
Merged

tls_config.go: don't swallow error #232

merged 1 commit into from
Aug 7, 2024

Conversation

Leonid99
Copy link
Contributor

@Leonid99 Leonid99 commented Aug 4, 2024

No description provided.

@Leonid99
tls_config.go: don't swallow error
4fe6e21 
Signed-off-by: Leonid Podolny <leonid@podolny.net>
SuperQ
SuperQ approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks!

@SuperQ SuperQ merged commit 0ed404d into prometheus:master Aug 7, 2024
4 checks passed
SuperQ added a commit that referenced this pull request Sep 1, 2024
@SuperQ
Release v0.12.0
d00760b 
* [FEATURE] Add pprof links to landing page #196
* [FEATURE] Support listen on vsock #220
* [ENHANCEMENT] Add hints for bash completion #190
* [ENHANCEMENT] Support kingpin.CmdClause as argument #238
* [BUGFIX] Don't swollow listen errors #232

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Sep 1, 2024
Merged
SuperQ added a commit that referenced this pull request Sep 3, 2024
@SuperQ
Release v0.12.0 (#246)
e078b1f 
* [FEATURE] Add pprof links to landing page #196
* [FEATURE] Support listen on vsock #220
* [ENHANCEMENT] Add hints for bash completion #190
* [ENHANCEMENT] Support kingpin.CmdClause as argument #238
* [BUGFIX] Don't swollow listen errors #232

Signed-off-by: SuperQ <superq@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leonid99 @SuperQ