display "target" to log msg #797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brant-lzh
force-pushed
the
feature/add_log_msg
branch
from
da523e0 to
f88edeb
Compare
|
This needs a rebase. |
|
@SuperQ So, what should be done? |
Signed-off-by: Brant <53347762+Brant-lzh@users.noreply.github.com>
Brant-lzh
force-pushed
the
feature/add_log_msg
branch
from
e6eacbc to
9a4dcba
Compare
|
@SuperQ Done. LGTM ! |
|
Sorry, this needs to be updated for the new logging system. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'd like to display the 'target' field in the logs for easier debugging.
OLD
ts=2023-12-19T02:53:31.516Z caller=exporter.go:152 level=error msg="Error pinging mysqld" err="Error 1045 (28000): Access denied for user 'testuser'@'127.0.0.1' (using password: YES)" ts=2023-12-19T02:53:35.076Z caller=exporter.go:152 level=error msg="Error pinging mysqld" err="Error 1045 (28000): Access denied for user 'testuser'@'127.0.0.1' (using password: YES)"NEW
ts=2023-12-19T02:53:31.516Z caller=exporter.go:152 level=error msg="Error pinging mysqld" target=1.2.3.4:3306 err="Error 1045 (28000): Access denied for user 'testuser'@'127.0.0.1' (using password: YES)" ts=2023-12-19T02:53:35.076Z caller=exporter.go:152 level=error msg="Error pinging mysqld" target=1.2.3.5:3306 err="Error 1045 (28000): Access denied for user 'testuser'@'127.0.0.1' (using password: YES)"