Update Juniper module

[jacobw]

Update Juniper module to include FRU, DOM and basic subscriber count. Also use EnumAsStateSet to support alerting.

[SuperQ]

I wonder if some of this should be a separate module, like juniper_optics.

[jacobw]

I used to break that out but found I keep on telling people they needed to add it, so I figure making it default makes it easier. It should only impact devices that have optics that support DOM.

[bastischubert]

I also used JUNIPER-DOM-MIB::jnxDomCurrentLaneTxLaserBiasCurrent to alert on "dying" optics when they start drawing more and more current.
We also used separate modules for basic juniper (switches,routers...) and more specific for devices with DOM support.

[jacobw]

I used to have jnxDomCurrentLaneTxLaserBiasCurrent but removed it because I didn't use it. I can see add that.

Regarding switches with DOM support, is there much benefit in removing it. Even small switches often have DOM for uplinks.

Happy to break DOM out though if that's the preference. My goal was to make life easier for users.

[SuperQ]

Since we added multi-module scrapes, I think splitting makes more sense. Users can request scrapes like if_mib,juniper,juniper_optics

[jacobw]

Ok I'll make the changes tonight.

[jacobw]

I've broken optics out into it's own module, and included jnxDomCurrentLaneTxLaserBiasCurrent.

I also remove the threshold items as you can look at the jnxDomCurrentWarnings and jnxDomCurrentAlarms for threshold breaches, rather than calculating manually.

[bastischubert]

Fine for me

[SuperQ]

Thanks