Add Printer pages counters #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @eflumerf thanks for your contribution ! |
|
Done! |
|
thx for fixing - can you please sign off the commits (see https://github.com/prometheus/snmp_exporter/pull/1353/checks?check_run_id=36656171662 ) then we should be ready to merge |
|
This needs a DCO sign-off. You can use |
eflumerf
force-pushed
the
main
branch
2 times, most recently
from
e80bd7f to
394f1e5
Compare
|
I signed off on the second commit, should I do both? |
Signed-off-by: Eric Flumerfelt <eflumerf@fnal.gov>
Signed-off-by: Eric Flumerfelt <eflumerf@fnal.gov>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen on https://mibbrowser.online/mibdb_search.php?mib=Printer-MIB