Remove auth label from collection metric #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `auth` label from the exporter collection duratoin histogram as it causes too much cardinality. Fixes: #978 Signed-off-by: SuperQ <superq@gmail.com>
|
Nice one. LGTM.
Don't know off-hand, is it on the target info?
Basti is on PTO this week.
Sent by mobile; please excuse my brevity.
…On Wed, Aug 30, 2023, 08:24 Ben Kochie ***@***.***> wrote:
👓 @bastischubert <https://github.com/bastischubert> @candlerb
<https://github.com/candlerb>
—
Reply to this email directly, view it on GitHub
<#981 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFYII4F7XYIVKBPSR5C4OLXX3MBLANCNFSM6AAAAAA4D7ZJSA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
/metrics vs /snmp. Question didn't make sense sorry
Sent by mobile; please excuse my brevity.
On Wed, Aug 30, 2023, 08:31 Richard Hartmann ***@***.***>
wrote:
… Nice one. LGTM.
Don't know off-hand, is it on the target info?
Basti is on PTO this week.
Sent by mobile; please excuse my brevity.
On Wed, Aug 30, 2023, 08:24 Ben Kochie ***@***.***> wrote:
> 👓 @bastischubert <https://github.com/bastischubert> @candlerb
> <https://github.com/candlerb>
>
> —
> Reply to this email directly, view it on GitHub
> <
#981 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAFYII4F7XYIVKBPSR5C4OLXX3MBLANCNFSM6AAAAAA4D7ZJSA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#981 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFYIIY4MEEEY54V43O6K4LXX3M47ANCNFSM6AAAAAA4D7ZJSA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
It's on |
|
I have tested this, now one histogram per module: LGTM. |
SuperQ
added a commit
that referenced
this pull request
Sep 1, 2023
* [BUGFIX] Remove auth label from collection metric #981 Signed-off-by: SuperQ <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Sep 1, 2023
* [BUGFIX] Remove auth label from collection metric #981 Signed-off-by: SuperQ <superq@gmail.com>
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
Remove the `auth` label from the exporter collection duratoin histogram as it causes too much cardinality. Fixes: prometheus#978 Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: Stephan Windischmann <windi@Stephans-MacBook-Pro.local>
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
* [BUGFIX] Remove auth label from collection metric prometheus#981 Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: Stephan Windischmann <windi@Stephans-MacBook-Pro.local>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
authlabel from the exporter collection duratoin histogram as it causes too much cardinality.Fixes: #978