Merge pull request #58 from siebertm/fix-gitlab-comment-duplication

Gitlab integration: comments are duplicated because of default 20-item pagination
prontolabs · Jan 29, 2015 · b1e0cc9 · b1e0cc9
2 parents 9a751e5 + c09bbdf
commit b1e0cc9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+### Changes
+
+* [#58](https://github.com/mmozuras/pronto/pull/58): GitlabFormatter uses a high +per_page+ value to avoid pagination (and thus duplicate comments)
 
 ## 0.4.0
 

diff --git a/lib/pronto/gitlab.rb b/lib/pronto/gitlab.rb
@@ -7,7 +7,7 @@ def initialize(repo)
 
     def commit_comments(sha)
       @comment_cache["#{sha}"] ||= begin
-        client.commit_comments(slug, sha).map do |comment|
+        client.commit_comments(slug, sha, per_page: 500).map do |comment|
           Comment.new(sha, comment.note, comment.path, comment.line)
         end
       end

diff --git a/spec/pronto/gitlab_spec.rb b/spec/pronto/gitlab_spec.rb
@@ -17,7 +17,7 @@ module Pronto
 
           ::Gitlab::Client.any_instance
                           .should_receive(:commit_comments)
-                          .with('mmozuras%2Fpronto', sha)
+                          .with('mmozuras%2Fpronto', sha, per_page: 500)
                           .once
                           .and_return([])