Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

GithubSpec Test Fails (Pronto::Github#create_pull_request_review with comments) #324

Closed
alessio-signorini opened this issue Dec 28, 2018 · 0 comments
Closed

GithubSpec Test Fails (Pronto::Github#create_pull_request_review with comments) #324

alessio-signorini opened this issue Dec 28, 2018 · 0 comments

Comments

@alessio-signorini
Copy link
Contributor

Master branch tests are failing with the following error

1) Pronto::Github#create_pull_request_review with comments 
     Failure/Error:
       octokit_client
         .should_not_receive(:create_pull_request_review)
         .with('prontolabs/pronto', pull_id, options)
         .once
     
     RuntimeError:
       `count` is not supported with negative message expectations
     # ./spec/pronto/github_spec.rb:170:in `block (4 levels) in <module:Pronto>'
@alessio-signorini alessio-signorini mentioned this issue Dec 28, 2018
Merged
@doomspork doomspork mentioned this issue Dec 29, 2018
Merged
apiology pushed a commit to apiology/pronto that referenced this issue Dec 27, 2019
@alessio-signorini @doomspork
Fix for GithubSpec Test (fixes prontolabs#324) (prontolabs#325)
c123aae 
* GithubSpec: fixed test

* Removed Ruby v2.2 from TravisCI (RubyGems deprecated it)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alessio-signorini