Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change Github review comment mode to "REQUEST_CHANGES" #320

Closed
wants to merge 1 commit into from
Closed

Change Github review comment mode to "REQUEST_CHANGES" #320

wants to merge 1 commit into from

Conversation

rnitta
Copy link

@rnitta rnitta commented Nov 1, 2018

Issue

#319

Implements

Just changed event from 'COMMENT' to 'REQUEST_CHANGES', which is submitted with github review comment.

@mmozuras
Copy link
Member

mmozuras commented Feb 3, 2019

@rnitta love it! Could you also make it configurable as per this suggestion? 😄

@gyfis gyfis mentioned this pull request Mar 19, 2019
Merged
@gyfis
Copy link
Contributor

gyfis commented Mar 19, 2019

@mmozuras @rnitta Hi, since this PR seems like it lost its traction, I took the liberty of creating a replacement PR that also implements the configurability: #334

@doomspork doomspork closed this Sep 19, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnitta @mmozuras @gyfis @doomspork