Skip to content

[Feature] Warn when kwargs passed to a Scenario are not used #117

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

matteobettini
Copy link
Member

@matteobettini matteobettini commented Jun 26, 2024

fixes #114

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 98.76543% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (66f3a02) to head (ecdd946).
Report is 1 commits behind head on main.

Files Patch % Lines
vmas/simulator/utils.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   87.83%   87.89%   +0.06%     
==========================================
  Files          81       81              
  Lines        8384     8434      +50     
==========================================
+ Hits         7364     7413      +49     
- Misses       1020     1021       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobettini matteobettini changed the title [Feature] Raise error of unitilized passed kwargs [Feature] Warn when kwargs passed to a Scenario are not used Jun 26, 2024
@matteobettini matteobettini merged commit fc52c9b into main Jun 26, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency with shared reward args name
1 participant