Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

@types/node is listed as a prod dependency, adds 2MB to package size (unnecessarily?) #2019

Open
ericallam opened this issue Aug 18, 2024 · 0 comments · May be fixed by #2030
Open

@types/node is listed as a prod dependency, adds 2MB to package size (unnecessarily?) #2019

ericallam opened this issue Aug 18, 2024 · 0 comments · May be fixed by #2030

Comments

@ericallam
Copy link

protobuf.js version: 7.3.3

@types/node should be listed as a devDependency. Here's the output of npmgraph showing the size of @types/node:

CleanShot 2024-08-18 at 21 53 32@2x
xPaw added a commit to xPaw/protobuf.js that referenced this issue Sep 17, 2024
@xPaw
Move @types/node to devDependencies
2427e5f 
Fixes protobufjs#2019
@xPaw xPaw linked a pull request Sep 17, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move @types/node to devDependencies xPaw/protobuf.js
1 participant
@ericallam