fixed 'error' is not defined linter warning when using static/static-module and es6 #833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a little problem while using protobuf.js with react.js
I used the following proto file:
with this compiler arguments:
pbjs -t static-module -p src/api/ -o gen/api.js src/api/messages.proto
Without the patch, the generated file contains this section:
The problem is, that second error has no 'let' keyword before it. That generates a build error when I require(...) the generated file.
With the patch it looks like this: