Actually fail if staleness fail #15984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 610833812
mkruskal-google
requested review from
zhangskz
and removed request for
a team
zhangskz
approved these changes
Feb 27, 2024
|
Maybe push to dev branch in protocolbuffers so test can actually run? (although I think you tested this already though) Sidenote: I thought we supposedly exempted ourselves from the "safe for tests" requirement? |
|
Nope, our forks aren't exempt. And this actually won't run tests from a fork because I touched workflows, changed the base |
mkruskal-google
requested review from
JasonLunn
and removed request for
a team
mkruskal-google
merged commit 489aba5
into
protocolbuffers:staleness-fix-25
1 check passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 610833812