Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove codes for unsupported Ruby #17353

Closed
wants to merge 1 commit into from

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Jul 7, 2024

Protocol Buffers only supports Ruby >= 3.0 since 360531c

@y-yagi y-yagi requested a review from a team as a code owner July 7, 2024 22:58
@y-yagi y-yagi requested review from JasonLunn and removed request for a team July 7, 2024 22:58
@JasonLunn JasonLunn added ruby 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jul 7, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 7, 2024
@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 8, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 8, 2024
@zhangskz
Copy link
Member

zhangskz commented Jul 8, 2024

Giving the tests another kick after a problem in our CI due to some github changes. Please feel free to give this a ping if you don't see this merged in the next day or so.

@zhangskz
Copy link
Member

zhangskz commented Jul 8, 2024

Actually, can you rebase past e1638dc?

@y-yagi y-yagi force-pushed the remove_codes_for_ruby27 branch from 5ca39fa to 6fa2c5b Compare July 8, 2024 23:12
@y-yagi
Copy link
Contributor Author

y-yagi commented Jul 8, 2024

Actually, can you rebase past e1638dc?

🙆‍♂️ I've rebased with the latest code.

@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 9, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 9, 2024
Protocol Buffers  only supports Ruby >= 3.0 since 360531c
@y-yagi y-yagi force-pushed the remove_codes_for_ruby27 branch from 6fa2c5b to 80571a4 Compare July 28, 2024 06:18
@y-yagi
Copy link
Contributor Author

y-yagi commented Jul 28, 2024

@zhangskz Just a friendly ping.

@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 28, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 28, 2024
@copybara-service copybara-service bot closed this in 184f3a3 Aug 1, 2024
@y-yagi y-yagi deleted the remove_codes_for_ruby27 branch August 1, 2024 22:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants