Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cherry-pick: Fix Bazel dependency cycle issue affecting Kythe #18768

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

acozzette
Copy link
Member

The fact that our :protobuf_nowkt target actually does depend on the well-known types is causing a dependency cycle for Kythe. This fixes that so that :protobuf_nowkt no longer depends on the well-known types.

PiperOrigin-RevId: 684160567

The fact that our `:protobuf_nowkt` target actually does depend on the
well-known types is causing a dependency cycle for Kythe. This fixes that so
that `:protobuf_nowkt` no longer depends on the well-known types.

PiperOrigin-RevId: 684160567
@acozzette acozzette requested a review from a team as a code owner October 10, 2024 17:19
@acozzette acozzette requested review from haberman and removed request for a team October 10, 2024 17:19
@acozzette acozzette added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 10, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 10, 2024
@acozzette acozzette changed the title Chery-pick: Fix Bazel dependency cycle issue affecting Kythe Cherry-pick: Fix Bazel dependency cycle issue affecting Kythe Oct 10, 2024
@acozzette acozzette merged commit 6df33a4 into protocolbuffers:29.x Oct 10, 2024
174 of 176 checks passed
@acozzette acozzette deleted the kythe-fix branch October 10, 2024 20:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants