Give Kotlin jars an OSGi Manifest #18812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deannagarcia
requested review from
haberman and
googleberg
and removed request for
a team and
haberman
deannagarcia
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
googleberg
approved these changes
Oct 14, 2024
deannagarcia
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
deannagarcia
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
Did you mean for this to be a draft PR? Or is this PR ready, and meant to land as a CL once approved? |
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Extend our Java OSGi library to have a version that works for Kotlin. Add a `protobuf_versioned_kt_jvm_library` that creates a bundle with the OSGi manifest and call that instead of `kt_jvm_library` for all our kotlin maven release targets. Closes #18812 COPYBARA_INTEGRATE_REVIEW=#18812 from deannagarcia:kotlinOSGi 81bab06 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18812 from deannagarcia:kotlinOSGi 81bab06 PiperOrigin-RevId: 686201830
deannagarcia
added a commit
to deannagarcia/protobuf
that referenced
this pull request
Oct 16, 2024
Extend our Java OSGi library to have a version that works for Kotlin. Add a `protobuf_versioned_kt_jvm_library` that creates a bundle with the OSGi manifest and call that instead of `kt_jvm_library` for all our kotlin maven release targets. Closes protocolbuffers#18812 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#18812 from deannagarcia:kotlinOSGi 81bab06 PiperOrigin-RevId: 686220820
deannagarcia
added a commit
to deannagarcia/protobuf
that referenced
this pull request
Oct 16, 2024
Extend our Java OSGi library to have a version that works for Kotlin. Add a `protobuf_versioned_kt_jvm_library` that creates a bundle with the OSGi manifest and call that instead of `kt_jvm_library` for all our kotlin maven release targets. Closes protocolbuffers#18812 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#18812 from deannagarcia:kotlinOSGi 81bab06 PiperOrigin-RevId: 686220820
deannagarcia
added a commit
to deannagarcia/protobuf
that referenced
this pull request
Oct 16, 2024
Give Kotlin jars an OSGi Manifest (protocolbuffers#18812) Extend our Java OSGi library to have a version that works for Kotlin. Add a `protobuf_versioned_kt_jvm_library` that creates a bundle with the OSGi manifest and call that instead of `kt_jvm_library` for all our kotlin maven release targets. Closes protocolbuffers#18812 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#18812 from deannagarcia:kotlinOSGi 81bab06 PiperOrigin-RevId: 686220820
zhangskz
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Give Kotlin jars an OSGi Manifest (#18812) Extend our Java OSGi library to have a version that works for Kotlin. Add a `protobuf_versioned_kt_jvm_library` that creates a bundle with the OSGi manifest and call that instead of `kt_jvm_library` for all our kotlin maven release targets. Closes #18812 COPYBARA_INTEGRATE_REVIEW=#18812 from deannagarcia:kotlinOSGi 81bab06 PiperOrigin-RevId: 686220820 * Use old name of rules_kotlin
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend our Java OSGi library to have a version that works for Kotlin. Add a
protobuf_versioned_kt_jvm_librarythat creates a bundle with the OSGi manifest and call that instead ofkt_jvm_libraryfor all our kotlin maven release targets.