Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ADD support for new coinbase CSV format (V4) #172

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Griffsano
Copy link
Contributor

The Coinbase CSV format changed (again) somewhere in 2023 or 2024. I noticed the following changes with respect to the previous version:

  • No header line ("You can use this transaction report to inform your likely tax obligations...") and change in number of empty lines
  • Number of columns changed to 11, with a newly introduced "ID" column (not used for tax calculation)
  • The following columns now contain the Euro symbol: Price at transaction, subtotal, total, fees
  • The following columns now contain negative numbers (if applicable): Quantity transacted, subtotal, total
  • The UTC time format changed

I hope this PR covers all changes in the CSV format. However, my Coinbase export is pretty short with a limited number of transaction types. Therefore, there may be further code changes necessary that are not covered by this PR.

@Griffsano Griffsano changed the title ADD support for new coinbase CSV format ADD support for new coinbase CSV format (V4) Jan 2, 2025
@provinzio
Copy link
Owner

provinzio commented Jan 2, 2025

Hey @Griffsano and happy to new year. Thanks for the contribution. Looks good to me so far. We can merge this and edit as soon as someone has a bigger file with more transaction data.

Please check the pipeline errors before I merge.

Edit: Sorry, I fucked up the linter warnings and haven't noticed so far... I fixed the warning.

@provinzio provinzio merged commit 7935b10 into provinzio:main Jan 2, 2025
1 of 3 checks passed
@Griffsano
Copy link
Contributor Author

Happy new year to you too @provinzio and thanks for merging!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants