Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

finding_uid is not unique in backup_recovery_point_encrypted and route53_dangling_ip_subdomain_takeover, cloudtrail_multi_region_enabled_logging_management_events #6138

Closed
banv opened this issue Dec 11, 2024 · 2 comments · Fixed by #6152
Assignees
Labels
bug provider/aws Issues/PRs related with the AWS provider severity/low Bug won't result in any noticeable breakdown of the execution.

Comments

@banv
Copy link

banv commented Dec 11, 2024

Steps to Reproduce

prowler -s backup route53 cloudtrail

The program output CSV file with the same finding_uid like that
prowler-aws-backup_recovery_point_encrypted-<AWS_ACCOUNT_ID>-ap-southeast-1-aps1-ec2-ami-backup-vault
prowler-aws-backup_recovery_point_encrypted-<AWS_ACCOUNT_ID>-ap-southeast-1-aps1-rds-backup-vault
prowler-aws-route53_dangling_ip_subdomain_takeover-<AWS_ACCOUNT_ID>-us-east-1-<RESOURCE_ID>
prowler-aws-cloudtrail_multi_region_enabled_logging_management_events-<AWS_ACCOUNT_ID>-ap-northeast-1-Members

Expected behavior

The finding_uid must be unique id

Actual Result with Screenshots or Logs

No Log

How did you install Prowler?

Cloning the repository from github.com (git clone)

Environment Resource

  1. Other (Local PC)

OS used

  1. MacOS

Prowler version

Prowler 5.1.0 (You are running the latest version, yay!)

Pip version

pip 23.3

Context

It's the same problem with #6105 and I think it may be happen with many check that using for/loop then append report to finding array like that

@banv banv added bug status/needs-triage Issue pending triage labels Dec 11, 2024
@MrCloudSec MrCloudSec self-assigned this Dec 11, 2024
@MrCloudSec
Copy link
Member

Hi @banv, thanks for the heads up! We will work on the fix asap.

@MrCloudSec MrCloudSec added severity/low Bug won't result in any noticeable breakdown of the execution. provider/aws Issues/PRs related with the AWS provider and removed status/needs-triage Issue pending triage labels Dec 11, 2024
@MrCloudSec
Copy link
Member

Hi @banv, I just did the PR with the fix, try it if you want and let us know if that fixes the issue. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug provider/aws Issues/PRs related with the AWS provider severity/low Bug won't result in any noticeable breakdown of the execution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants