-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(aws): set unique resource IDs #6152
fix(aws): set unique resource IDs #6152
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6152 +/- ##
=======================================
Coverage 89.95% 89.96%
=======================================
Files 1152 1153 +1
Lines 35680 35702 +22
=======================================
+ Hits 32095 32118 +23
+ Misses 3585 3584 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this but my concern is that this will trigger new
findings since we are changing/fixing the UID format.
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Context
Fix #6138
Description
Set unique resource IDs in
backup_recovery_point_encrypted
,route53_dangling_ip_subdomain_takeover
andcloudtrail_multi_region_enabled_logging_management_events
checks.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.