Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(aws): set unique resource IDs #6152

Merged

Conversation

MrCloudSec
Copy link
Member

Context

Fix #6138

Description

Set unique resource IDs in backup_recovery_point_encrypted, route53_dangling_ip_subdomain_takeover and cloudtrail_multi_region_enabled_logging_management_events checks.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners December 11, 2024 21:15
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Dec 11, 2024
@MrCloudSec MrCloudSec added backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (fdb1956) to head (1bb954b).
Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6152   +/-   ##
=======================================
  Coverage   89.95%   89.96%           
=======================================
  Files        1152     1153    +1     
  Lines       35680    35702   +22     
=======================================
+ Hits        32095    32118   +23     
+ Misses       3585     3584    -1     
Flag Coverage Δ
prowler 89.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.96% <100.00%> (+<0.01%) ⬆️
api ∅ <ø> (∅)

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this but my concern is that this will trigger new findings since we are changing/fixing the UID format.

@jfagoagas jfagoagas merged commit 7b1a047 into master Dec 13, 2024
13 checks passed
@jfagoagas jfagoagas deleted the PRWLR-5726-finding-uid-is-not-unique-in-several-checks branch December 13, 2024 12:00
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 13, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
3 participants