Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(gcp): do not require organization id to get projects #5637

Conversation

MrCloudSec
Copy link
Member

Description

Do not require organization id to get projects so the test connection does not fail.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners November 5, 2024 13:52
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (ea03808) to head (52bdc1e).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5637      +/-   ##
==========================================
+ Coverage   89.81%   89.84%   +0.03%     
==========================================
  Files        1113     1113              
  Lines       34506    34515       +9     
==========================================
+ Hits        30990    31009      +19     
+ Misses       3516     3506      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit a109cd2 into master Nov 5, 2024
11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5174-do-not-require-organization-id-in-test-connection branch November 5, 2024 17:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
provider/gcp Issues/PRs related with the Google Cloud Platform provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants