Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(aws): Update check metadata with logging category #5639

Merged

Conversation

sansns
Copy link
Contributor

@sansns sansns commented Nov 5, 2024

Context

Update categories for logging checks

Description

Update check metadata to include logging category

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sansns sansns requested review from a team as code owners November 5, 2024 15:16
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 5, 2024
@sansns sansns changed the title feat(aws): Update check metadata with a category feat(aws): Update check metadata with logging category Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (1b50fdb) to head (430574a).
Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5639      +/-   ##
==========================================
+ Coverage   89.80%   89.82%   +0.02%     
==========================================
  Files        1112     1114       +2     
  Lines       34490    34536      +46     
==========================================
+ Hits        30973    31023      +50     
+ Misses       3517     3513       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec
Copy link
Member

@sansns why are you putting "forensics-ready" in some of them?

@sansns
Copy link
Contributor Author

sansns commented Nov 5, 2024

@sergargar Added it to elbv2 logging specifically as traffic coming into a NLB or ALB is routinely inspected. Any incident will also have the traffic to and from the resources as well as app specific interactions reviewed extensively.

This can be removed if it is not applicable.

@MrCloudSec MrCloudSec merged commit 77c7986 into prowler-cloud:master Nov 12, 2024
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants