Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ec2): add default value to Name key for image information #5747

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Nov 13, 2024

Context

If EC2 image does not have a name the function return an exception with KeyError.

Description

Add default None value to not return the exception and continue with code execution.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners November 13, 2024 11:52
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 13, 2024
@puchy22 puchy22 added backport-to-v3 Backport PR to the v3 branch backport-to-v4.5 labels Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (5641160) to head (c4a3940).
Report is 737 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5747      +/-   ##
==========================================
+ Coverage   89.83%   89.87%   +0.03%     
==========================================
  Files        1128     1128              
  Lines       35154    35154              
==========================================
+ Hits        31582    31595      +13     
+ Misses       3572     3559      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas merged commit 622bc48 into master Nov 13, 2024
13 checks passed
@jfagoagas jfagoagas deleted the PRWLR-5353-solve-error-with-ec-2-name-image branch November 13, 2024 14:22
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Nov 13, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v3
v4.5

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@jfagoagas jfagoagas added the backport-to-v4.5 Backport PR to the v4.5 branch label Dec 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-to-v3 Backport PR to the v3 branch backport-to-v4.5 Backport PR to the v4.5 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants