fix(wafv2): only list resources for regional Web ACLs

[HugoPBrito]

Context

An WAFInvalidParameterException error message was appearing while listing resources due to global ACLs being included in the call, which isn't supported by boto3.

Fix #5805

Description

Logic behind this error has been corrected and _list_resources_for_web_acl only lists regional ACLs.

Checklist

• Are there new checks included in this PR? No.
• Review if the code is being covered by tests.
• Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
• Review if backport is needed.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[jfagoagas]

Why not to catch the exception?

[MrCloudSec]

Why not to catch the exception?

This exception won't appear again with this change since we were using this call for Global Web ACLs and only works for regional ones.

[HugoPBrito]

Why not to catch the exception?

AWS does not support _list_resources_for_web_acl in global ACLs, because that listing has to be done in Cloudfront side:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/wafv2/client/list_resources_for_web_acl.html

I don't see the point of catching it if we can avoid the failing scenario instead.

[jfagoagas]

Thank you for the clarification @HugoPBrito @MrCloudSec ❤️

[HugoPBrito]

Thank you for the clarification @HugoPBrito @MrCloudSec ❤️

🫶

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (a25a614) to head (98bb17e).
Report is 705 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5811   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files        1132     1132           
  Lines       35275    35275           
=======================================
+ Hits        31703    31705    +2     
+ Misses       3572     3570    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[prowler-bot]

💚 All backports created successfully

Status	Branch	Result
✅	v4.5

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details