-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(aurora): Add default ports to the check of using non default ports #5821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @madslundholmdk thank you for this fix! Could you please add some tests to cover it? I can help you if you need guidance.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5821 +/- ##
==========================================
+ Coverage 89.91% 89.98% +0.07%
==========================================
Files 1133 1153 +20
Lines 35308 35701 +393
==========================================
+ Hits 31747 32126 +379
- Misses 3561 3575 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…L default/non-default ports
Hi @jfagoagas I have now added a couple of tests to ensure it's working as expected. |
@madslundholmdk Thank you! One question, are you using the |
...providers/aws/services/rds/rds_cluster_non_default_port/rds_cluster_non_default_port_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @madslundholmdk !
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Context
When using Aurora RDS clusters/instances, they are marked as using non-default port, even though the default port are in use.
Description
The Aurora engines has been added to the list of default ports to the respective default port.
Checklist
If you find tests necessary, please let me know and I will add some tests.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.