Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(aurora): Add default ports to the check of using non default ports #5821

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

madslundholmdk
Copy link
Contributor

@madslundholmdk madslundholmdk commented Nov 19, 2024

Context

When using Aurora RDS clusters/instances, they are marked as using non-default port, even though the default port are in use.

Description

The Aurora engines has been added to the list of default ports to the respective default port.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@madslundholmdk madslundholmdk requested review from a team as code owners November 19, 2024 07:07
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 19, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @madslundholmdk thank you for this fix! Could you please add some tests to cover it? I can help you if you need guidance.

@jfagoagas jfagoagas changed the title Add Aurora default ports to the check of using non default ports fix(aurora): Add default ports to the check of using non default ports Nov 19, 2024
@jfagoagas jfagoagas self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.98%. Comparing base (f01ce84) to head (e075b0b).
Report is 754 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5821      +/-   ##
==========================================
+ Coverage   89.91%   89.98%   +0.07%     
==========================================
  Files        1133     1153      +20     
  Lines       35308    35701     +393     
==========================================
+ Hits        31747    32126     +379     
- Misses       3561     3575      +14     
Flag Coverage Δ
prowler 89.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.98% <ø> (+0.07%) ⬆️
api ∅ <ø> (∅)

@madslundholmdk
Copy link
Contributor Author

Hi @jfagoagas
I'm happy to be able to help with this project.

I have now added a couple of tests to ensure it's working as expected.

@jfagoagas
Copy link
Member

@madslundholmdk Thank you!

One question, are you using the pre-commit since I see several lint steps failing, could you please follow this guide https://docs.prowler.com/projects/prowler-open-source/en/latest/developer-guide/introduction/#contributing-with-your-code-or-fixes-to-prowler? I can help you if you encounter any issue.

@MrCloudSec MrCloudSec added backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch labels Dec 11, 2024
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @madslundholmdk !

@MrCloudSec MrCloudSec merged commit bd9673c into prowler-cloud:master Dec 11, 2024
13 checks passed
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 11, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants