feat(ec2): add new fixer ec2_ebs_public_snapshot_fixer
#5825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Develop a fixer that reconfigures EBS snapshots to restrict public accessibility, ensuring they are only accessible within authorized AWS accounts or specific VPCs. This will protect sensitive data from being exposed to the public, securing critical information stored within the EBS snapshots.
For the unit tests, I've tried to use moto but it didn't work as expected, I've also tried to mock volumes as it's done in the unit tests of the check
ec2_ebs_public_snapshot
, but this created lots of snapshot so it was not easy to handle, so finally I decided to use Botocore.Also, an additional consideration is that I didn't realized that I commited the changes from this PR on this branch, so those changes are here to, that's why I need the reviewer to go to the other PR first.
Description
Added new fixer
ec2_ebs_public_snapshot_fixer
with its unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.