-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(tests): use datetime.datetime.now()
in GCP kms_key_rotation_enabled
#5976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5976 +/- ##
==========================================
- Coverage 92.86% 89.94% -2.93%
==========================================
Files 58 1147 +1089
Lines 4919 35608 +30689
==========================================
+ Hits 4568 32026 +27458
- Misses 351 3582 +3231
|
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Description
Use
datetime.datetime.now()
in the tests of GCP checkkms_key_rotation_enabled
.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.