Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(tests): use datetime.datetime.now() in GCP kms_key_rotation_enabled #5976

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

MrCloudSec
Copy link
Member

Description

Use datetime.datetime.now() in the tests of GCP check kms_key_rotation_enabled.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners November 30, 2024 19:33
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Nov 30, 2024
Copy link
Member

@toniblyx toniblyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (add2134) to head (a4d1c17).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5976      +/-   ##
==========================================
- Coverage   92.86%   89.94%   -2.93%     
==========================================
  Files          58     1147    +1089     
  Lines        4919    35608   +30689     
==========================================
+ Hits         4568    32026   +27458     
- Misses        351     3582    +3231     
Components Coverage Δ
prowler 89.94% <ø> (∅)
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec merged commit 17c31c6 into master Nov 30, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the fix-gcp-test branch November 30, 2024 20:31
@MrCloudSec MrCloudSec added the backport-to-v3 Backport PR to the v3 branch label Dec 6, 2024
prowler-bot pushed a commit that referenced this pull request Dec 6, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 6, 2024
@MrCloudSec MrCloudSec added backport-to-v4.6 Backport PR to the v4.6 branch and removed backport-to-v3 Backport PR to the v3 branch was-backported The PR was successfully backported to the target branch backport-to-v4.6 Backport PR to the v4.6 branch labels Dec 9, 2024
@prowler-bot
Copy link
Collaborator

💔 All backports failed

Status Branch Result
4.6 The branch "4.6" does not exist

Manual backport

To create the backport manually run:

backport --pr 5976

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@MrCloudSec MrCloudSec added backport-to-v4.6 Backport PR to the v4.6 branch and removed backport-to-v4.6 Backport PR to the v4.6 branch labels Dec 9, 2024
prowler-bot pushed a commit that referenced this pull request Dec 9, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch provider/gcp Issues/PRs related with the Google Cloud Platform provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants