-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(aws): get firewall manager managed rule groups #6119
fix(aws): get firewall manager managed rule groups #6119
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6119 +/- ##
==========================================
- Coverage 89.99% 89.97% -0.03%
==========================================
Files 1148 1149 +1
Lines 35629 35644 +15
==========================================
+ Hits 32066 32070 +4
- Misses 3563 3574 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Please, check my comment and add a test in the service for this use case. Thanks!
(cherry picked from commit 8d4b091)
(cherry picked from commit 8d4b091)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Context
Firewall Manager
managedrule groups
were previously not being accounted for, resulting in false positives.Fix #6030
Description
This issue has now been corrected, and false positives should no longer occur.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.