Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(aws): get firewall manager managed rule groups #6119

Merged

Conversation

HugoPBrito
Copy link
Member

Context

Firewall Manager managed rule groups were previously not being accounted for, resulting in false positives.

Fix #6030

Description

This issue has now been corrected, and false positives should no longer occur.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners December 10, 2024 17:01
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (f2f196c) to head (36054fd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6119      +/-   ##
==========================================
- Coverage   89.99%   89.97%   -0.03%     
==========================================
  Files        1148     1149       +1     
  Lines       35629    35644      +15     
==========================================
+ Hits        32066    32070       +4     
- Misses       3563     3574      +11     
Flag Coverage Δ
prowler 89.97% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.97% <100.00%> (-0.03%) ⬇️
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec changed the title fix: added firewall manager managed rule groups fix(aws): get firewall manager managed rule groups Dec 10, 2024
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Please, check my comment and add a test in the service for this use case. Thanks!

@MrCloudSec MrCloudSec self-requested a review December 10, 2024 18:43
@MrCloudSec MrCloudSec added backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch labels Dec 10, 2024
@MrCloudSec MrCloudSec merged commit 8d4b091 into master Dec 10, 2024
12 of 13 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5699-fix-false-positive-on-wafv-2-webacl-with-rules branch December 10, 2024 19:34
prowler-bot pushed a commit that referenced this pull request Dec 10, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 10, 2024
prowler-bot pushed a commit that referenced this pull request Dec 10, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on wafv2_webacl_with_rules when when ACL provisioned with AWS Firewall Manager
3 participants