fix(db-utils): fix batch_delete function #6283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6283 +/- ##
==========================================
+ Coverage 90.10% 93.74% +3.64%
==========================================
Files 1182 65 -1117
Lines 36300 6189 -30111
==========================================
- Hits 32708 5802 -26906
+ Misses 3592 387 -3205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AdriiiPRodri
approved these changes
Dec 20, 2024
MrCloudSec
deleted the
PRWLR-5845-fix-pagination-bug-on-batch-delete-for-providers
branch
prowler-bot
added
the
was-backported
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
Paginator, it would not iterate over more objects than the value of thebatch_size.We have fixed this and included a proper test for it.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.