Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(api): change the inserted_at.lte unittest #6403

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

AdriiiPRodri
Copy link
Contributor

@AdriiiPRodri AdriiiPRodri commented Jan 9, 2025

Context

In this PR we are going to fix an error detected in the unit tests of the API, specifically this error is related to the insertion date of a finding.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AdriiiPRodri AdriiiPRodri requested a review from jfagoagas January 9, 2025 11:25
@AdriiiPRodri AdriiiPRodri requested a review from a team as a code owner January 9, 2025 11:25
@AdriiiPRodri AdriiiPRodri added the backport This PR contains a backport label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (80311d3) to head (35be4ce).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6403      +/-   ##
==========================================
+ Coverage   90.10%   93.78%   +3.67%     
==========================================
  Files        1183       65    -1118     
  Lines       36333     6211   -30122     
==========================================
- Hits        32738     5825   -26913     
+ Misses       3595      386    -3209     
Flag Coverage Δ
api 93.78% <ø> (?)
prowler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 93.78% <ø> (∅)

@AdriiiPRodri AdriiiPRodri merged commit 4652174 into master Jan 9, 2025
12 checks passed
@AdriiiPRodri AdriiiPRodri deleted the fix-findings-unittest branch January 9, 2025 12:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport This PR contains a backport component/api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants