Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Bump Pydantic to 2.9.2 Using the v1 API #137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

robodair
Copy link

@robodair robodair commented Nov 5, 2024

Context

Bumping the Pydantic Library to Version 2 allows this to be used with https://github.com/svdimchenko/pydantic-glue for generating AWS Glue Schema definitions using the Pydantic Models.

See the Migration Guide

Description

Pydantic Updated to ^2.9.2

All from pydantic .... import statements changed to from pydantic.v1 ... as per the Pydantic migration guide.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@robodair robodair requested a review from a team as a code owner November 5, 2024 22:40
@jfagoagas jfagoagas changed the title Bump Pydantic to 2.9.2 Using the v1 API chore: Bump Pydantic to 2.9.2 Using the v1 API Nov 6, 2024
@jfagoagas
Copy link
Member

Hello @robodair we will review it as soon as possible.

Thanks!

@jfagoagas
Copy link
Member

@robodair could you verify the issues with the poetry.lock since it seems to be not updated? https://github.com/prowler-cloud/py-ocsf-models/actions/runs/11693707732/job/32580298241?pr=137

@robodair
Copy link
Author

robodair commented Nov 6, 2024

@robodair could you verify the issues with the poetry.lock since it seems to be not updated? https://github.com/prowler-cloud/py-ocsf-models/actions/runs/11693707732/job/32580298241?pr=137

@jfagoagas updated now! Sorry, made my branch off the existing PR for bumping Pydantic and didn't update the lock file.

@jfagoagas
Copy link
Member

@robodair could you verify the issues with the poetry.lock since it seems to be not updated? prowler-cloud/py-ocsf-models/actions/runs/11693707732/job/32580298241?pr=137

@jfagoagas updated now! Sorry, made my branch off the existing PR for bumping Pydantic and didn't update the lock file.

That's fine, thanks for the quick response.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b366488) to head (f5cd9d1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines          741       741           
=========================================
  Hits           741       741           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robodair
Copy link
Author

robodair commented Nov 7, 2024

This would be necessary to support #138

@jfagoagas
Copy link
Member

@robodair Sorry for the late notice but we'll try to review this next week. Thank you for your patience.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants