-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Bump Pydantic to 2.9.2 Using the v1 API #137
base: main
Are you sure you want to change the base?
Conversation
Hello @robodair we will review it as soon as possible. Thanks! |
@robodair could you verify the issues with the |
@jfagoagas updated now! Sorry, made my branch off the existing PR for bumping Pydantic and didn't update the lock file. |
That's fine, thanks for the quick response. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 741 741
=========================================
Hits 741 741 ☔ View full report in Codecov by Sentry. |
This would be necessary to support #138 |
@robodair Sorry for the late notice but we'll try to review this next week. Thank you for your patience. |
Context
Bumping the Pydantic Library to Version 2 allows this to be used with https://github.com/svdimchenko/pydantic-glue for generating AWS Glue Schema definitions using the Pydantic Models.
See the Migration Guide
Description
Pydantic Updated to ^2.9.2
All
from pydantic ....
import statements changed tofrom pydantic.v1 ...
as per the Pydantic migration guide.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.