Pass slice instead of Vec during map serialization. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: utils::bench_serialize_map ... bench: 66.87 ns/iter (+/- 1.33) utils::bench_serialize_map_bytes ... bench: 69.42 ns/iter (+/- 1.45) After: utils::bench_serialize_map ... bench: 55.84 ns/iter (+/- 1.16) utils::bench_serialize_map_bytes ... bench: 56.03 ns/iter (+/- 1.19) Note that this is changed only in the private functions to avoid breaking the public API. Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
PiotrSikora
force-pushed
the
serialize-slices
branch
from
a5ca5c8 to
74218ba
Compare
mpwarres
approved these changes
Nov 26, 2024
Swaagie
approved these changes
Dec 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
utils::bench_serialize_map ... bench: 66.87 ns/iter (+/- 1.33)
utils::bench_serialize_map_bytes ... bench: 69.42 ns/iter (+/- 1.45)
After:
utils::bench_serialize_map ... bench: 55.84 ns/iter (+/- 1.16)
utils::bench_serialize_map_bytes ... bench: 56.03 ns/iter (+/- 1.19)
Note that this is changed only in the private functions to avoid breaking
the public API.