Skip to content

Some minor tweaks #25

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Some minor tweaks #25

wants to merge 4 commits into from

Conversation

ch3pjw
Copy link

@ch3pjw ch3pjw commented May 21, 2025

Just trying out this package and reading through the source code. I made a couple of minor tweaks for your consideration:

  • The main one, functionally, is not to have a bare except, but specify Exception so that we don't run the risk of hanging forever by catching KeyboardInterrupt erroneously.
  • I updated some type annotations that were causing some noise in my editor, which lead to a minor update for how password is passed to pymysql.connect.
  • I changed some whitespace that was likewise causing some noise.

ch3pjw added 4 commits May 21, 2025 15:40
@ch3pjw
Catch explicit Exception
0a320dd 
So that it `c.ping()` hangs forever, the interrupt from a users Ctrl+C
will still cause the process to terminate.
@ch3pjw
Fix type annotation
7b0e162
@ch3pjw
Annotate password type and adapt for PyMySql cursor interface
0a24efe 
This was giving a type error in my IDE.
@ch3pjw
Formatting
8f2d7ca 
This was giving some easy-to-fix errors in my IDE.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ch3pjw