minor changes to pademu

[belek666]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

Some small corrections and code clean-ups.

[J013k]

Any test version before merging it?

[belek666]

OPNPS2LD.zip
Commit doesn't change much but ds4 should be less delayed now.

[KrahJohlito]

@J013k
You already tested this build yea?
I did a quick test and it seemed all good, no regression and changes do what are intended.

[J013k]

No, I don't have any additional regression with DS3.

Unfortunately I don't have DS4, so I cannot test recent updates to notice if delay has been reduced.

[carl0sjt]

I've tested with Dualshock 4. Controller is well responsive. Seems okay with most games. Some issues still remains:

• controller vibrates on cutscenes, when game is paused (resident evil 4)
• Real PS2 controller still vibrates when using PAD emu even when PADEMU is set to port 1/2 and REAL controller is connected to the port that correspond virtual pad. eg. If PADEMU port 1 vibrates, the real controller connect to controller port 1 will vibrate too.
• Midnight Club 3 crashes at boot.
• Its confusing to pair the controller. Some times it connects to other devices instead of PS2.

No regressions on this PR. :)

[KrahJohlito]

Since this PR does as intended without breaking anything, can this be merged please?

It’s not about fixing all current issues with PADEMU but I’m sure it’s still helpful to see the current remaining issues.

Best regards

[ElPatas1]

Hello,

merged, although it would be nice to fix the remaining issues.

Best regards.

[KrahJohlito]

Yes I agree, sorry to seem impatient we just needed the changes merged before submitting more changes for approval.

Thank you