Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Source control optimization #436

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Source control optimization #436

merged 2 commits into from
Jun 15, 2021

Conversation

AKuHAK
Copy link
Member

@AKuHAK AKuHAK commented Jun 15, 2021

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

@AKuHAK AKuHAK requested a review from uyjulian June 15, 2021 09:43
@AKuHAK
Copy link
Member Author

AKuHAK commented Jun 15, 2021

Finally removed SMS network exclusion from clang, also added some clang formatting options. @uyjulian can you check if everything is ok?
@KrahJohlito I can try to apply the same formatting to SMS source code.

@uyjulian
Copy link
Member

I like the definition alignment.

However, I think it would be better to avoid formatting the lwIP code to make it easier to sync with upstream and upgrade in the future.

@AKuHAK
Copy link
Member Author

AKuHAK commented Jun 15, 2021

However, I think it would be better to avoid formatting the lwIP code to make it easier to sync with upstream and upgrade in the future.

Ah, that was a point. Ok Ill revert changes in that folder.

BTW thank you that you restored the OPL master branch, I accidentally overwrite it yesterday, really my fault.

@AKuHAK
Copy link
Member Author

AKuHAK commented Jun 15, 2021

I like the definition alignment.

However, I think it would be better to avoid formatting the lwIP code to make it easier to sync with upstream and upgrade in the future.

I just realized that you already run formatting on that folder in fce8f32
Maybe we can keep this PR as is? cause all files are already heavily formatted.

@uyjulian
Copy link
Member

Sure. I'll merge then

@uyjulian uyjulian merged commit 08fc57b into ps2homebrew:master Jun 15, 2021
@AKuHAK AKuHAK deleted the clang-format12 branch June 15, 2021 13:46
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants