Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix CI with latest flake8-bugbear #3412

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Fix CI with latest flake8-bugbear #3412

merged 3 commits into from
Dec 9, 2022

Conversation

JelleZijlstra
Copy link
Collaborator

Description

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Dec 9, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request Dec 9, 2022
Merged
3 tasks
@JelleZijlstra
Copy link
Collaborator Author

strict= is only in 3.10+. I'm going to disable the lint rule instead until we drop support for 3.9.

cooperlees
cooperlees approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yes - We should disable this. Forgot we had all optional enabled here.

Thanks!

@JelleZijlstra JelleZijlstra merged commit 19c5fe4 into psf:main Dec 9, 2022
@JelleZijlstra JelleZijlstra deleted the flake branch December 9, 2022 04:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @cooperlees