Use regex where we ignore case on windows #4252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was just about to start testing things, and was running into failed tests on
main
. Bothtest_invalid_gitignore
andtest_invalid_nested_gitignore
both threw errors because of the case-sensitivity of"s" in "STRING"
withgitignore
beingc:\\...
and the output havingC:\\...
.On windows the path
FoObAR
is the same asfoobar
, so the output ofblack
on a windows machine could output the path to.gitignore
with upper or lower-case portions of the path. In this change we use the regexre.IGNORECASE
flag to get it to match properly. We do not do this when thegitignore
path is not apathlib.WindowsPath
object.Checklist - did you ...
CHANGES.md
if necessary? - not necessaryUpdated test output