Fix GnuPG configuration menu crash and add ECC subkey type #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no default case for key algorithm other than RSA, DSA and elGamal. Parsing keys of other types result in incomplete "rows" enum filling which later cause crash in Model::showKeys as could not find Fingerprint field and row.at(Fingerprint) resulted in NULL pointer. This commit adds default case and new ECC subkey type.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no default case for key algorithm other than RSA, DSA and elGamal.
Parsing keys of other types result in incomplete "rows" enum filling
which later cause crash in Model::showKeys as could not find Fingerprint field and
row.at(Fingerprint) resulted in NULL pointer.
This commit adds default case and new ECC subkey type.