[Image Plugin] Fix MIME type and encoding #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The file extension might not be the correct MIME type, and is empty for images extracted from the clipboard 2. The image is converted to a JPEG, anyway
|
I believe we should somehow consider http://tools.ietf.org/html/rfc3548#section-4 |
|
I don't think so: http://tools.ietf.org/html/rfc2397#section-4 After digging a bit deeper, https://tools.ietf.org/html/rfc4648#section-5 suggest encoding '=', but then again rfc2397 doesn't specify to use base64url, and I see no conflict as described in https://tools.ietf.org/html/rfc3986#section-2.2 |
|
ok. agreed. |
wadealer
added a commit
that referenced
this pull request
Jun 20, 2014
[Image Plugin] Fix MIME type and encoding
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to actually display images from clipboard and images with faulty extensions in clients strictly adhering to the claimed MIME type.