Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add searching for work in progress Gerrit changes #187

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Add searching for work in progress Gerrit changes #187

merged 1 commit into from
Feb 6, 2019

Conversation

hferreiro
Copy link
Contributor

Add support for searching CLs marked as "Work in progress". These are
CLs for which the code review hasn't started yet. The submitted CLs
report is changed to omit these WIP CLs. Additionally, remove support
for drafts ('is:draft') which isn't available in Gerrit anymore and
probably had the same purpose.

Add support for searching CLs marked as "Work in progress". These are
CLs for which the code review hasn't started yet. The submitted CLs
report is changed to omit these WIP CLs. Additionally, remove support
for drafts ('is:draft') which isn't available in Gerrit anymore and
probably had the same purpose.
@hferreiro
Copy link
Contributor Author

I'm not sure what's the purpose of limit_since. Can anyone clarify?

@psss psss self-assigned this Feb 6, 2019
psss added a commit that referenced this pull request Feb 6, 2019
@psss
Copy link
Owner

psss commented Feb 6, 2019

Looks good. Thanks for the patch. Regarding the limit_since parameter: I don't know all the implementation details of the gerrit plugin. It was originally written by @mcepl. Maybe he might have some hint...

@psss psss merged commit 689c6a5 into psss:master Feb 6, 2019
psss added a commit to mweetman-redhat/did that referenced this pull request Jan 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants