Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use type aliases for <eventcopy> and <errorcopy> definitions #391

Merged
merged 3 commits into from
May 3, 2020

Conversation

eduardosm
Copy link
Collaborator

Reduces the amount of parse and serialize code.

Copy link
Owner

@psychon psychon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that gets rid of lots of code.

It means that the Debug implementations now sometimes print the wrong type name, but I guess that's something people have to live with. The context should make it clear which kind of event/error they actually have.

@mergify mergify bot merged commit a4dc2a1 into master May 3, 2020
@mergify mergify bot deleted the event-error-copy branch May 3, 2020 05:40
@psychon
Copy link
Owner

psychon commented May 3, 2020

I was curious. Just the last commit has this stat:

 5 files changed, 1258 insertions(+), 5543 deletions(-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants